Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-16033: Update docs on default RRD #6459

Merged
merged 4 commits into from
Aug 4, 2023
Merged

NMS-16033: Update docs on default RRD #6459

merged 4 commits into from
Aug 4, 2023

Conversation

mmahacek
Copy link
Contributor

@mmahacek mmahacek commented Jul 31, 2023 •
edited
Loading

Consolidate RRD text across poller and collect configs by reusing the same text on both.

All Contributors

External References

@mmahacek mmahacek self-assigned this Jul 31, 2023
@github-actions github-actions bot added the docs label Jul 31, 2023
dino2gnt
dino2gnt previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@dino2gnt dino2gnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmahacek mmahacek marked this pull request as ready for review July 31, 2023 22:04
@mmahacek mmahacek requested a review from Bonrob2 July 31, 2023 22:05
Bonrob2
Bonrob2 suggested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor changes.

docs/modules/operation/pages/deep-dive/retention.adoc Outdated Show resolved Hide resolved
docs/modules/operation/pages/deep-dive/retention.adoc Outdated Show resolved Hide resolved
docs/modules/operation/pages/deep-dive/retention.adoc Outdated Show resolved Hide resolved
docs/modules/operation/pages/deep-dive/retention.adoc Outdated Show resolved Hide resolved
docs/modules/operation/pages/deep-dive/retention.adoc Outdated Show resolved Hide resolved
docs/modules/operation/pages/deep-dive/retention.adoc Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from Bonrob2 August 1, 2023 16:26
Bonrob2
Bonrob2 previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@github-actions github-actions bot requested a review from Bonrob2 August 1, 2023 18:37
Bonrob2
Bonrob2 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmahacek mmahacek merged commit 8d7ed01 into foundation-2023 Aug 4, 2023
3 of 4 checks passed
@mmahacek mmahacek deleted the jira/mm/NMS-16033-rrd-docs branch August 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bonrob2 Bonrob2 Bonrob2 approved these changes

@dino2gnt dino2gnt dino2gnt left review comments

@ProjectJYL ProjectJYL Awaiting requested review from ProjectJYL

@sriraagworks sriraagworks Awaiting requested review from sriraagworks

@garcia-sr garcia-sr Awaiting requested review from garcia-sr

Assignees

@mmahacek mmahacek

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmahacek @dino2gnt @Bonrob2