Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-64: Add meta descriptions to each page in the operation guide. #6376

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

Bonrob2
Copy link
Contributor

@Bonrob2 Bonrob2 commented Jul 14, 2023

Added description tags for events, alarms, notifications, and business service monitoring sections.

All Contributors

Contribution Checklist

  • Please make an issue in the OpenNMS issue tracker if there isn't one already.
    Once there is an issue, please:
    1. update the title of this PR to be in the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the Jira link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
    4. once you've created this PR, please link to it in a comment in the Jira issue
      Don't worry if this sounds like a lot, we can help you get things set up properly.
  • If this code is likely to affect the UI, did you name your branch with -smoke in it to trigger smoke tests?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it try to avoid changing files in $OPENNMS_HOME/etc/?

What's Next?

A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.

If you need help making additions or changes to the documentation related to your changes, please let us know.

In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.

Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

Added description tags for events, alarms, notifications, and business service monitoring sections.
@Bonrob2 Bonrob2 requested a review from mmahacek July 14, 2023 20:07
@github-actions github-actions bot added the docs label Jul 14, 2023
@Bonrob2 Bonrob2 requested a review from mmahacek July 17, 2023 13:59
mmahacek
mmahacek previously approved these changes Jul 17, 2023
@Bonrob2 Bonrob2 changed the base branch from develop to foundation-2023 July 17, 2023 14:48
@Bonrob2 Bonrob2 dismissed mmahacek’s stale review July 17, 2023 14:48

The base branch was changed.

@Bonrob2
Copy link
Contributor Author

Bonrob2 commented Jul 17, 2023

@mmahacek , realized I had the wrong target branch, so updated, but after you approved.

@Bonrob2 Bonrob2 requested a review from mmahacek July 17, 2023 15:08
Copy link
Contributor

@mmahacek mmahacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bonrob2 Bonrob2 merged commit 5028987 into foundation-2023 Jul 20, 2023
4 checks passed
@Bonrob2 Bonrob2 deleted the jira/DP-64b branch July 20, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants