NMS-15134: Default to direction 'unknown' when the direction field #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is not present in Netflow9 or IPFIX flows. This allows for bidirectional flows to work properly when the exporter does not include the field. Tested with a RB5009 on MikroTik RouterOS 7.6.
fooker
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://opennms.atlassian.net/browse/NMS-15134
Marks NF9 and IPFIX flows with direction=UNKNOWN unless explicitly set in the template.
I also needed to regenerate the Protobuf classes - they seemed out-of-sync with the .proto definition - direction values of UNKNOWN coming from JSON failed to deserialize.