Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-15803: Minion container doc update #6285

Merged
merged 2 commits into from
Jun 28, 2023
Merged

NMS-15803: Minion container doc update #6285

merged 2 commits into from
Jun 28, 2023

Conversation

mmahacek
Copy link
Contributor

@mmahacek mmahacek commented Jun 27, 2023 •
edited
Loading

Updating Minion Docker install instructions with some changes found during an install call today.
Also sneaking in an omitted attribute in the common poller parameter configs.

All Contributors

External References

@mmahacek mmahacek self-assigned this Jun 27, 2023
@github-actions github-actions bot added the docs label Jun 27, 2023
@github-actions github-actions bot requested a review from Bonrob2 June 27, 2023 23:52
marshallmassengill
marshallmassengill approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@marshallmassengill marshallmassengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Bonrob2
Bonrob2 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2!

@mmahacek mmahacek merged commit 1e9bb0e into foundation-2023 Jun 28, 2023
4 checks passed
@mmahacek mmahacek deleted the jira/mm/NMS-15803 branch June 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshallmassengill marshallmassengill marshallmassengill approved these changes

@Bonrob2 Bonrob2 Bonrob2 approved these changes

Assignees

@mmahacek mmahacek

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmahacek @marshallmassengill @Bonrob2