NMS-15768: Fixed scan-interval handling #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christianpape
commented
Jun 27, 2023
christianpape
commented
- JIRA: https://opennms.atlassian.net/browse/NMS-15768
RangerRick
suggested changes
Jun 27, 2023
| @@ -57,10 +57,13 @@ public String marshal(final Duration v) { | |||
| /** {@inheritDoc} */ | |||
| @Override | |||
| public Duration unmarshal(final String v) { | |||
| if ("0".equals(v)) { | |||
| if ("0".equals(v.trim())) { | |||
There was a problem hiding this comment.
Could v ever be null? This would introduce an NPE if so...
There was a problem hiding this comment.
null-check added
| @@ -39,10 +39,14 @@ public class StringIntervalPropertyEditor extends PropertyEditorSupport implemen | |||
| /** {@inheritDoc} */ | |||
| @Override | |||
| public void setAsText(final String text) throws IllegalArgumentException { | |||
| if ("0".equals(text)) { | |||
| if ("0".equals(text.trim())) { | |||
There was a problem hiding this comment.
null-check added
RangerRick
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.