Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-15788: switch Horizon 33 to UBI #6258

Merged
merged 11 commits into from
Jun 30, 2023
Merged

Conversation

RangerRick
Copy link
Contributor

This PR merges our changes to the base container to use RedHat's UBI.

External References

@RangerRick RangerRick requested a review from j-white June 26, 2023 21:15
fooker
fooker previously approved these changes Jun 27, 2023
Copy link
Member

@fooker fooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but there is nothing that immediately stands out

christianpape
christianpape previously approved these changes Jun 28, 2023
Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: DJ Gregor <[email protected]>
@RangerRick RangerRick dismissed stale reviews from christianpape and fooker via 256e72d June 28, 2023 14:03
mershad-manesh
mershad-manesh previously approved these changes Jun 28, 2023
Copy link
Contributor

@mershad-manesh mershad-manesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good to me

Co-authored-by: DJ Gregor <[email protected]>
@RangerRick RangerRick merged commit de93eea into develop Jun 30, 2023
4 checks passed
@RangerRick RangerRick deleted the jira/NMS-15788-ubi-in-h33 branch June 30, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants