From 1d0f81e4fe641b10281cf50b4bb3a6684b0b4119 Mon Sep 17 00:00:00 2001 From: Jeff Gehlbach Date: Mon, 23 Aug 2021 14:20:53 -0400 Subject: [PATCH] - Corrected arithmetic error affecting pollsCompletedPerSec and, on RRD-based installs, metricsPersistedPerSec - Bumped version to 1.3 --- pom.xml | 2 +- src/main/java/org/opennms/netmgt/brannock/Brannock.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index d26d25b..2355095 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ 4.0.0 org.opennms.tools brannock - 1.1 + 1.3 OpenNMS Features Brannock bundle diff --git a/src/main/java/org/opennms/netmgt/brannock/Brannock.java b/src/main/java/org/opennms/netmgt/brannock/Brannock.java index 5db145f..70b3c1b 100644 --- a/src/main/java/org/opennms/netmgt/brannock/Brannock.java +++ b/src/main/java/org/opennms/netmgt/brannock/Brannock.java @@ -132,7 +132,7 @@ private Double derivePollsPerSec() { if (m_vmUptime != null && m_vmUptime != 0 && m_pollerTasksCompleted != null) { - pps = m_pollerTasksCompleted.doubleValue() / m_vmUptime.doubleValue() / 1000.0; + pps = m_pollerTasksCompleted.doubleValue() * 1000.0 / m_vmUptime.doubleValue(); } else { pps = Double.MIN_VALUE; } @@ -148,7 +148,7 @@ private Double deriveMetricsPerSec() { } else if (m_vmUptime != null && m_enqueuedOps != null && m_enqueuedOps > 0) { - mps = m_enqueuedOps.doubleValue() / m_vmUptime.doubleValue() / 1000.0; + mps = m_enqueuedOps.doubleValue() * 1000.0 / m_vmUptime.doubleValue(); } else if (m_enqueuedOps == 0) { mps = new Double(0); } else {