NEWTS-132: Add 5 exceptional-behavior tests #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Dear @RangerRick Could you please provide the feedback for this pull request? I believe ading tests would increase the coverage and the quality for the project. Thank you! |
Hey, sorry, I'm no longer an admin for this repo, so I'm not sure I can get this over the finish line, but at first glance it looks reasonable. @fooker or @christianpape (or someone else) mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://opennms.atlassian.net/browse/NEWTS-132
Add exceptional behavior tests to cover throw statements.