-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging changes #35
Merging changes #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an initial review--I'll get back to it later after I have some more time, but I wanted to give you these few pieces of feedback sooner.
Also: it looks like the github linter found a few issues, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* adding initial support for OpenShift * update scc and statefulset * fix references to OpenShift * remove hardcoded values * add Openshift support for OPG * update Sentinel * disable hardcoded routerCanonicalHostname and fix end of file * fix logics and detect other container types * clean up logic * remove html formatting from Notes file * modify readme file * add a file listing known issues and limitations * Add options to control creation of ClusterRole and ClusterRoleBinding * Revert "fix logics and detect other container types" This reverts commit 64a8224. * add initial doc for 1.1.0-Beta1 * allow pull secrets to be used by minion; fix a small bug in values schema for pull secrets * remove extra file * Merging changes (#35) * NMS-16166 - Allow user to control allowPrivilegeEscalation, allowedCapabilities, defaultAddCapabilities * Disable Ingress if className is not set * remove defaultAddCapabilities from values file * clean up * Update chart version * fix a typo * address lint issues * remove extra logic * enable the security context for plugins and clean up * drop all capabilities when CAP is not assigned * fix the securityContext options * fix lint issues * fix lint issue in core * clean up the logic for setting fsGroup * add imagePullSecrets to post-config job * change the default etcUpdatePolicy policy * Add OpenShift docs for Horizon and Minion * fix a small bug with opg route * remove comments * fix a small issue with password change path * fix a small bug in minion deployment * Update horizon/templates/grafana-helm.route.yaml Co-authored-by: DJ Gregor <[email protected]> * fix spacing * fix lint issue * fix indentations * fix lint issue * add logic for using latest datasources and password --------- Co-authored-by: DJ Gregor <[email protected]> --------- Co-authored-by: DJ Gregor <[email protected]>
New additions: