Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-13540: Highlight search terms in result page #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fooker
Copy link
Member

@fooker fooker commented Dec 13, 2022

This changes the version of antora-lunr-extension to our own for which implements the required functionality: https://github.com/opennms-forge/antora-lunr-extension.

To use the changes in antora-lunr-extension, the builder image has to be updated, too.
See opennms-forge/opennms-base-container#26.

In addition, a PR for upstream has been created: https://gitlab.com/antora/antora-lunr-extension/-/merge_requests/90.

@fooker fooker force-pushed the jira/NMS-13540 branch 7 times, most recently from a89c0a3 to 9091c08 Compare December 13, 2022 13:10
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to test this, but thanks for doing all the work.

@fooker fooker force-pushed the jira/NMS-13540 branch 4 times, most recently from 98fafa7 to 3bacf95 Compare January 26, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants