Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove syft dependency for dataloaders #73

Open
TTitcombe opened this issue Nov 24, 2020 · 1 comment
Open

Remove syft dependency for dataloaders #73

TTitcombe opened this issue Nov 24, 2020 · 1 comment
Assignees
@TTitcombe
Labels
Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Milestone
Syft 0.4

Comments

@TTitcombe
Copy link
Member

What?

Remove the syft dataset/dataloader dependency from the VerticalDataset/loaders. Inherit instead from torch dataset/loader

Why?

Those classes are not present in syft >= 0.3.0
@TTitcombe TTitcombe added the Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase label Nov 24, 2020
@TTitcombe TTitcombe added this to the Syft 3.2 milestone Nov 24, 2020
@TTitcombe TTitcombe self-assigned this Nov 24, 2020
@RohitJain001
Copy link

RohitJain001 commented Mar 13, 2021 •
edited
Loading

@TTitcombe is this open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TTitcombe TTitcombe

Labels
Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Projects
None yet
Milestone
Syft 0.4
Development

No branches or pull requests
2 participants
@TTitcombe @RohitJain001