Add support for custom weight specification during cross partition combining #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ighest weight. Also, fix comment lines.
dvadym
reviewed
Jul 21, 2023
|
|
||
| def __init__(self, dp_metrics: List[pipeline_dp.Metrics], | ||
| public_partitions: bool): | ||
| AccumulatorType = Tuple[Tuple, metrics.UtilityReport, Tuple[float]] |
There was a problem hiding this comment.
Please extend the comment above about AccumulatorType structure
There was a problem hiding this comment.
added comment, but better to improve it. will do.
dvadym
reviewed
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we just combine all partitions equally during utility analysis. We want to allow clients do it in a more elaborate way, giving them some set of predefined good weighing functions and allowing them to specify their own. For example, we can provide them with a weighing function that weighs based on the contribution of the partition (e.g. in case of COUNT metric, it is partitions size).