Convert messages to nls format #419

awisniew90 · 2023-07-25T16:03:09Z

No description provided.

scottkurz

I see why we ended up "repeating ourselves" in the case where we issue a Trace and then basically the same error message.

In some cases we might end up using a much shorter trace msg with no worries about being in common.

Just curious, if you wanted to do grab the message in English and trace it, is there an easy way to do that with the NLS API? Or would you end up having to go load the properties file "manually" (with File read APIs) ? Just curious.

It seems a shame to have the redundancy but if we end up "breaking the link" it wouldn't look as bad.

scottkurz · 2023-07-25T16:10:28Z

bundles/io.openliberty.tools.eclipse.ui/META-INF/MANIFEST.MF

@@ -29,6 +29,7 @@ Import-Package: org.eclipse.core.commands,
 org.eclipse.jdt.launching,
 org.eclipse.jem.util.emf.workbench,
 org.eclipse.osgi.service.debug,
+ org.eclipse.osgi.util;version="1.1.0",


Seems like we'd want to avoid tying to a specific version unless there's a special need.

According to this stackoverflow answer, it doesnt look like we'd be able to lookup messages outside the current locale.
https://stackoverflow.com/questions/21334606/using-eclipse-externalized-strings-how-to-get-a-string-in-language-xyz

I think moving forward we'd be less aligned with the messages printed in trace and the user facing messages (tracing being less formal or shorter, like you said).

awisniew90 · 2023-07-25T17:02:48Z

@dmuelle - Last time you had reviewed these messages, we did not have them consolidated in an nls props file. This PR does that, and we found a few messages that we had missed in the last ID review. Specifically, the last 7 messages here (line 78 and on): https://github.com/OpenLiberty/liberty-tools-eclipse/pull/419/files#diff-bc509bee7031fd55ada2ddb5421c7c609abbb0b4f8ccac213f15dfad7ed9c4a8

Would you be able to review those final 7 as well?

dmuelle

ID review- lmk if you have any questions. Thanks!

dmuelle · 2023-07-25T18:46:13Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+# NLS_MESSAGEFORMAT_VAR
+
+# DebugModeHandler
+multiple_server_env=More than one server.env file was found for project {0}. Unable to determine which server.env file to use.


Suggested change

multiple_server_env=More than one server.env file was found for project {0}. Unable to determine which server.env file to use.

multiple_server_env=More than one server.env file was found for the {0} project. Unable to determine which server.env file to use.

dmuelle · 2023-07-25T18:46:54Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+
+# DevModeOperations
+start_no_project_found=An error was detected when the start request was processed. The object that represents the selected project was not found.
+start_already_issued=The start request was already issued on project {0}. Use the stop action before you select the start action.


Suggested change

start_already_issued=The start request was already issued on project {0}. Use the stop action before you select the start action.

start_already_issued=The start request was already issued on the {0} project. Use the stop action before you select the start action.

dmuelle · 2023-07-25T18:47:11Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+# DevModeOperations
+start_no_project_found=An error was detected when the start request was processed. The object that represents the selected project was not found.
+start_already_issued=The start request was already issued on project {0}. Use the stop action before you select the start action.
+start_general_error=An error was detected during the start request on project {0}.


Suggested change

start_general_error=An error was detected during the start request on project {0}.

start_general_error=An error was detected during the start request on the {0} project.

dmuelle · 2023-07-25T18:47:30Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+start_general_error=An error was detected during the start request on project {0}.
+
+start_container_no_project_found=An error was detected when the start in container request was processed. The object that represents the selected project was not found.
+start_container_already_issued=The start in container request was already issued on project {0}. Use the stop action before you select the start action.


Suggested change

start_container_already_issued=The start in container request was already issued on project {0}. Use the stop action before you select the start action.

start_container_already_issued=The start in container request was already issued on the {0} project. Use the stop action before you select the start action.

dmuelle · 2023-07-25T18:47:43Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+
+start_container_no_project_found=An error was detected when the start in container request was processed. The object that represents the selected project was not found.
+start_container_already_issued=The start in container request was already issued on project {0}. Use the stop action before you select the start action.
+start_container_general_error=An error was detected during the start in container request on project {0}.


Suggested change

start_container_general_error=An error was detected during the start in container request on project {0}.

start_container_general_error=An error was detected during the start in container request on the {0} project.

dmuelle · 2023-07-25T19:04:19Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+java_resolution_error=Unable to resolve the Java installation path by using configuration {0}. Using the workspace Java installation.
+
+# LaunchConfigurationDelegateLauncher
+launch_config_error=An error was detected when configuration was launched {0}.


what is {0} here? the error or the config?

dmuelle · 2023-07-25T19:05:32Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+# ExplorerMenuHandler
+project_not_valid=The project is not valid. Be sure to select a project first.
+menu_command_retrieve_error=Unable to retrieve menu command.
+menu_command_process_error=Unable to process menu command {0} on project {1}.


Suggested change

menu_command_process_error=Unable to process menu command {0} on project {1}.

menu_command_process_error=Unable to process menu the {0} command on the {1} project.

dmuelle · 2023-07-25T19:07:27Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+menu_command_process_error=Unable to process menu command {0} on project {1}.
+
+# CommandBuilder
+maven_exec_not_found=Could not find Maven executable or wrapper.


what Could not find Maven executable or wrapper? Add a subject to the sentence if possible

dmuelle · 2023-07-25T19:07:52Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+gradle_exec_not_found=Could not find Gradle executable or wrapper.
+
+# Project
+determine_java_project_error=Unable to determine if project {0} is a Java project.


Suggested change

determine_java_project_error=Unable to determine if project {0} is a Java project.

determine_java_project_error=Unable to determine if the {0} project is a Java project.

dmuelle · 2023-07-25T19:09:07Z

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

+
+# Project
+determine_java_project_error=Unable to determine if project {0} is a Java project.
+liberty_nature_add_error=Error querying and adding Liberty nature.


Suggested change

liberty_nature_add_error=Error querying and adding Liberty nature.

liberty_nature_add_error=An error occurred with querying and adding the Liberty nature.

awisniew90 · 2023-07-25T19:41:57Z

Thanks @dmuelle - changed made and ready for re-review 👍

dmuelle

a few more minor edits

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties

Signed-off-by: Adam Wisniewski <[email protected]>

awisniew90 · 2023-07-26T13:07:57Z

@dmuelle - all good now 👍

dmuelle

LGTM, thanks!

scottkurz

LGTM

awisniew90 requested a review from scottkurz July 25, 2023 16:03

scottkurz requested changes Jul 25, 2023

View reviewed changes

awisniew90 force-pushed the nls_messages branch from 58eaea7 to 59ed29c Compare July 25, 2023 16:55

awisniew90 requested a review from dmuelle July 25, 2023 17:00

dmuelle requested changes Jul 25, 2023

View reviewed changes

awisniew90 force-pushed the nls_messages branch from 59ed29c to 1c370f2 Compare July 25, 2023 19:41

dmuelle reviewed Jul 25, 2023

View reviewed changes

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties Outdated Show resolved Hide resolved

...o.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/messages/Messages.properties Outdated Show resolved Hide resolved

Convert messages to nls format

06cef57

Signed-off-by: Adam Wisniewski <[email protected]>

awisniew90 force-pushed the nls_messages branch from 1c370f2 to 06cef57 Compare July 26, 2023 13:07

dmuelle approved these changes Jul 26, 2023

View reviewed changes

scottkurz approved these changes Jul 26, 2023

View reviewed changes

scottkurz merged commit f531671 into OpenLiberty:main Jul 26, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert messages to nls format #419

Convert messages to nls format #419

awisniew90 commented Jul 25, 2023

scottkurz left a comment

scottkurz Jul 25, 2023

awisniew90 Jul 25, 2023

awisniew90 commented Jul 25, 2023

dmuelle left a comment

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

dmuelle Jul 25, 2023

awisniew90 commented Jul 25, 2023

dmuelle left a comment

awisniew90 commented Jul 26, 2023

dmuelle left a comment

scottkurz left a comment

	multiple_server_env=More than one server.env file was found for project {0}. Unable to determine which server.env file to use.
	multiple_server_env=More than one server.env file was found for the {0} project. Unable to determine which server.env file to use.

	start_already_issued=The start request was already issued on project {0}. Use the stop action before you select the start action.
	start_already_issued=The start request was already issued on the {0} project. Use the stop action before you select the start action.

	start_general_error=An error was detected during the start request on project {0}.
	start_general_error=An error was detected during the start request on the {0} project.

	start_container_already_issued=The start in container request was already issued on project {0}. Use the stop action before you select the start action.
	start_container_already_issued=The start in container request was already issued on the {0} project. Use the stop action before you select the start action.

	start_container_general_error=An error was detected during the start in container request on project {0}.
	start_container_general_error=An error was detected during the start in container request on the {0} project.

	menu_command_process_error=Unable to process menu command {0} on project {1}.
	menu_command_process_error=Unable to process menu the {0} command on the {1} project.

	determine_java_project_error=Unable to determine if project {0} is a Java project.
	determine_java_project_error=Unable to determine if the {0} project is a Java project.

	liberty_nature_add_error=Error querying and adding Liberty nature.
	liberty_nature_add_error=An error occurred with querying and adding the Liberty nature.

Convert messages to nls format #419

Convert messages to nls format #419

Conversation

awisniew90 commented Jul 25, 2023

scottkurz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awisniew90 commented Jul 25, 2023

dmuelle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awisniew90 commented Jul 25, 2023

dmuelle left a comment

Choose a reason for hiding this comment

awisniew90 commented Jul 26, 2023

dmuelle left a comment

Choose a reason for hiding this comment

scottkurz left a comment

Choose a reason for hiding this comment