Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ServerLevel, ServerPlayer, Level, ClientLevel for phase 1 #16

Conversation

seelderr
Copy link
Contributor

No description provided.

@seelderr seelderr changed the title Marking ClientLevel for phase 2/3 Implemented ServerLevel, ServerPlayer, Level, ClientLevel for phase 1 Jan 21, 2024
@CursedFlames
Copy link
Member

I'll go through and update param names after #21 is merged.

Copy link
Member

@NotStirred NotStirred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes to logic, and a nit.

Also you're missing mixin comments explaining what they should do!

@NotStirred NotStirred merged commit 22f8605 into OpenCubicChunks:MC_1.20_neoforge Jan 24, 2024
1 check passed
@seelderr seelderr deleted the MC_1.20_neoforge_clientlevel branch January 27, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants