Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Apply the Bulk Relationship POC on all required entities (#7500) #8294

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Sep 9, 2024

Proposed changes

  • root file : jsx to tsx
  • forceUpdate added on knowledge tabs

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Sep 9, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (9a5f2b3) to head (211a929).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8294      +/-   ##
==========================================
+ Coverage   66.24%   66.27%   +0.03%     
==========================================
  Files         597      597              
  Lines       60315    60341      +26     
  Branches     6197     6233      +36     
==========================================
+ Hits        39954    39990      +36     
+ Misses      20361    20351      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard self-assigned this Sep 10, 2024
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, I tested navigation on all screen

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review September 10, 2024 14:45
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title [frontend] js to ts root file, knowledge force update hook added (#4352) [frontend] Apply the Bulk Relationship POC on all required entities (#7500) Sep 10, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran merged commit ceb72b4 into master Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants