Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Align design and fix new datatable (#7906) #8269

Merged
merged 64 commits into from
Sep 13, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Sep 6, 2024

Proposed changes

  • UI and UX fixes for datatable component.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@labo-flg labo-flg force-pushed the oob/fix-data-tables branch 2 times, most recently from 0d923ad to 2267530 Compare September 6, 2024 10:13
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 6, 2024
@labo-flg labo-flg changed the title [frontend] Additional fix on new datatable (#7906) [frontend] Align design and fix new datatable (#7906) Sep 11, 2024
@lndrtrbn lndrtrbn marked this pull request as ready for review September 12, 2024 16:26
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (5d6f8bb) to head (c0799d3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8269   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files         597      597           
  Lines       60339    60339           
  Branches     6202     6207    +5     
=======================================
+ Hits        39954    39956    +2     
+ Misses      20385    20383    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg merged commit 621d98a into master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants