Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add logs in CSV ingestion manager #7981

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Aug 7, 2024

Proposed changes

  • Add logs to facilitate debug on csv ingestion manager because we had hard time debugging stuff

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Aug 7, 2024
@lndrtrbn lndrtrbn self-assigned this Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 14.70588% with 29 lines in your changes missing coverage. Please review.

Project coverage is 68.17%. Comparing base (b6391c8) to head (09c8994).
Report is 24 commits behind head on master.

Files Patch % Lines
...rm/opencti-graphql/src/manager/ingestionManager.ts 7.69% 24 Missing ⚠️
...-platform/opencti-graphql/src/database/rabbitmq.js 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7981      +/-   ##
==========================================
+ Coverage   67.70%   68.17%   +0.47%     
==========================================
  Files         570      574       +4     
  Lines       70592    71316     +724     
  Branches     6013     6545     +532     
==========================================
+ Hits        47792    48619     +827     
+ Misses      22800    22697     -103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn merged commit 8c88143 into master Aug 8, 2024
9 of 10 checks passed
@lndrtrbn lndrtrbn deleted the poc/add-logs-ingest branch August 8, 2024 09:29
@lndrtrbn lndrtrbn restored the poc/add-logs-ingest branch August 8, 2024 09:29
@SamuelHassine SamuelHassine deleted the poc/add-logs-ingest branch August 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants