Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Improve csv feed #6151

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[backend] Improve csv feed #6151

merged 1 commit into from
Feb 28, 2024

Conversation

richard-julien
Copy link
Member

No description provided.

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 28, 2024
@richard-julien richard-julien self-assigned this Feb 28, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 66.84%. Comparing base (d9ecbdc) to head (800d3c2).
Report is 1 commits behind head on master.

Files Patch % Lines
...platform/opencti-graphql/src/parser/csv-bundler.ts 87.50% 2 Missing ⚠️
...-platform/opencti-graphql/src/parser/csv-parser.ts 88.23% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6151      +/-   ##
==========================================
+ Coverage   66.67%   66.84%   +0.17%     
==========================================
  Files         540      540              
  Lines       64323    64349      +26     
  Branches     5247     5371     +124     
==========================================
+ Hits        42888    43017     +129     
+ Misses      21435    21332     -103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Kedae
Kedae reviewed Feb 28, 2024
View reviewed changes
opencti-platform/opencti-front/src/private/components/data/ingestionCsv/IngestionCsvLine.tsx
@@ -57,6 +57,7 @@ const ingestionCsvLineFragment = graphql`
uri
ingestion_running
current_state_date
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this date is never valued. Am I missing something ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, need to be deleted in the future

@richard-julien richard-julien merged commit 79bc968 into master Feb 28, 2024
10 checks passed
@richard-julien richard-julien deleted the oob/improve_csv_feed branch February 28, 2024 09:46
@JeremyCloarec JeremyCloarec mentioned this pull request Mar 20, 2024
Closed
Archidoit pushed a commit that referenced this pull request Jun 6, 2024
@richard-julien @Archidoit
[backend] Improve csv feed parse to allow partial reject (#6151)
21ad0c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kedae Kedae Kedae left review comments

Assignees

@richard-julien richard-julien

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-julien @Kedae