Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix position of ai button #6128

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 27, 2024

Proposed changes

  • Update position of ai button in RichTextField variant html

Related issues

  • Overlay between fullscreen button and ai button

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@frapuks frapuks self-assigned this Feb 27, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.73%. Comparing base (32b3537) to head (a65db8a).
Report is 2 commits behind head on master.

❗ Current head a65db8a differs from pull request most recent head af1c73a. Consider uploading reports for the commit af1c73a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6128   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files         540      540           
  Lines       64184    64184           
  Branches     5241     5242    +1     
=======================================
+ Hits        42833    42836    +3     
+ Misses      21351    21348    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine
Copy link
Member

Can you post a screenshot of the new position please?

@marieflorescontact
Copy link
Member

Can you post a screenshot of the new position please?

image

@SamuelHassine
Copy link
Member

Can you check the behavior in Report => Content => New HTML file?

@frapuks
Copy link
Member Author

frapuks commented Feb 27, 2024

Can you check the behavior in Report => Content => New HTML file?

Broken
image

expected behaviour is this ?
image

Update : add style to differentiate 2 cases

@SamuelHassine SamuelHassine merged commit ec560ec into master Feb 27, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/position-ai-button branch February 27, 2024 10:58
Archidoit pushed a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants