Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in sharing inferred relations Post-Bug Fix #7389

Open
yassine-ouaamou opened this issue Jun 17, 2024 · 5 comments · May be fixed by #8572
Open

Inconsistency in sharing inferred relations Post-Bug Fix #7389

yassine-ouaamou opened this issue Jun 17, 2024 · 5 comments · May be fixed by #8572
Assignees
Labels
bug use for describing something not working as expected inference linked to the inference rule engine

Comments

@yassine-ouaamou
Copy link
Member

yassine-ouaamou commented Jun 17, 2024

Description

This issue is related to #6990
The inferred relations included in reports shared prior to this bug fix remain unshared. However, the newly established relations are now shared.

Todo

  • Create migration to align current shared containers
  • Improve inference engine to directly add the correct sharing at creation

Environment

Testing (6.1.11)

@yassine-ouaamou yassine-ouaamou added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jun 17, 2024
@yassine-ouaamou yassine-ouaamou changed the title Reports that have been shared before Inconsistency in sharing inferred relations Post-Bug Fix Jun 17, 2024
@SamuelHassine
Copy link
Member

Also, following the bugfix #6990:

The inference engine needs also to be patched for the use case:

  1. Share a report with an organization
  2. Add something in the report that triggers an inference rule
  3. Inference came => not shared!

@SamuelHassine
Copy link
Member

@nino-filigran Customer(s) impacted here.

@nino-filigran
Copy link

Thanks for pointing me out this one, I've missed it. I'll take it internally with devs.

@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Jun 18, 2024
@nino-filigran nino-filigran added this to the Bugs backlog milestone Jun 18, 2024
@Kedae Kedae modified the milestones: Release 6.1.12, Release 6.2.0 Jun 19, 2024
@lndrtrbn lndrtrbn self-assigned this Jun 24, 2024
@Jipegien Jipegien modified the milestones: Release 6.2.0, Release 6.3.0 Jun 24, 2024
@Jipegien Jipegien added the inference linked to the inference rule engine label Jul 1, 2024
@Kedae Kedae modified the milestones: Release 6.2.1, Release 6.3.0 Jul 2, 2024
@lndrtrbn lndrtrbn linked a pull request Oct 2, 2024 that will close this issue
5 tasks
@lndrtrbn lndrtrbn linked a pull request Oct 2, 2024 that will close this issue
5 tasks
@lndrtrbn
Copy link
Member

lndrtrbn commented Oct 2, 2024

I've asked for help from someone with more backend skills to write the migration

@Lhorus6
Copy link

Lhorus6 commented Oct 2, 2024

Note: This issue seems to cover this one also : #8197

Thanks for the work @lndrtrbn, two customers have been waiting a long time for it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected inference linked to the inference rule engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants