feat: US aid grades #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
musoke
force-pushed
the
aid-one-scale
branch
2 times, most recently
from
addb0a4
to
7169224
Compare
musoke
force-pushed
the
aid-one-scale
branch
3 times, most recently
from
591fbdc
to
38e6ca2
Compare
|
@actuallyyun, could you take a look at this and tell me if it seems sensible as an initial implementation? |
Add a US scale for aid grades. It treats A# and C# as being part of the same scale, so that different grade contexts do not need to be assigned to neighbouring routes, e.g. if there is a grade with grade A2 next to a route with grade C1. Aid + mandatory free is not covered by this commit. Resolves: OpenBeta#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scale for US aid grades.
It treats A# and C# as being part of the same scale, so that different grade contexts do not need to be assigned to neighbouring routes, e.g. if there is a grade with grade A2 next to a route with grade C1.
Aid + mandatory free is not covered by this commit.
Resolves: #79
I have separated this from my first (partial) impl in #93 in case someone wants to check the alternative.