fix: add exports field to package.json #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4fbbd0 added `"typde": "module"` to `package.json`. This broke importing of sandbag in openbeta-graphql. package.json also needs an exports field, telling it which modules are exposed for export. Add it. Also update to typescript ^4.9.5, a version which supports `package.json` exports. See https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing Fixes OpenBeta#123
|
I haven't been following CommonJS and ESM as a library author. Since we use |
Yes, it seems to be. After reading those docs, I think the fix in this PR is correct. |
vnugent
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e4fbbd0 added
"typde": "module"topackage.json. This broke importing of sandbag in openbeta-graphql.package.json also needs an exports field, telling it which modules are exposed for export. Add it.
Also update to typescript ^4.9.5, a version which supports
package.jsonexports. Seehttps://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing
Fixes #123