Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Fix the order of topics in the navbar #98

Open
ejaxon opened this issue Nov 24, 2018 · 2 comments
Open

Fix the order of topics in the navbar #98

ejaxon opened this issue Nov 24, 2018 · 2 comments
Assignees

Comments

@ejaxon
Copy link
Contributor

ejaxon commented Nov 24, 2018

Use of 'map' to generate the navbar yields an arbitrary order of menu items. Should mirror the order in the current site.

@mmazanec22
Copy link
Contributor

@ejaxon I ordered them and named them in a branch, but this does mean that they are hard coded and an API call is unnecessary to populate the nav bar. I didn't take out the API call yet in case we wanted to discuss including "display name" and "order in nav bar" or something like that in the db.

@ejaxon
Copy link
Contributor Author

ejaxon commented Dec 10, 2018

I think it makes sense to do something other than hard-code, but that's a couple nice small tasks for later.

Why don't you go ahead and merge this is, then reassign the task to me. I'm not sure what the right approach is, given that this is using a general Open Referral endpoint. Maybe a special endpoint for this application, maybe a more general set of additional fields like you suggest. I'll think about it, then re-implementing the front-end piece will be a nice small task for a newbie React programmer.

@mmazanec22 mmazanec22 assigned ejaxon and unassigned mmazanec22 Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants