-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refact/#362 chat domain #367
Conversation
Test Results76 testsโโโ76 โ
โโ2s โฑ๏ธ Results for commit d926a78. โป๏ธ This comment has been updated with latest results. |
@@ -28,15 +26,12 @@ public ChatMessage save(ChatMessage chatMessage, String collectionName) { | |||
return mongoTemplate.save(chatMessage, collectionName); | |||
} | |||
|
|||
public CursorPaginationResult<ChatDataApiRes> findAllByCollection(String collectionName, | |||
CursorPaginationInfoReq pageable) { | |||
public List<ChatMessage> findAllByCollection(String collectionName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CursorPaginationResult ํ์ ์ด ์๋ List ํ์ ์ผ๋ก ๋ณ๊ฒฝํ๋ฉด์ 'cursorId๋ก ๋ฐ์ ๊ฐ๋ถํฐ ๊ฐ์ ธ์ค๊ฒ ํ๋ค' ๋ผ๊ณ ์ดํด๊ฐ ๋์๋๋ฐ ๋ง๋์?๐ค
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ง์ต๋๋ค ๐๐ป
private final LocalDateTime meetStartTime; | ||
private final LocalDateTime meetEndTime; | ||
|
||
private ChatRoomDetail(Long projectId, MeetingInfo meetingInfo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๋ฐ์ ์ผ๋ก ๋ณด์์ ๋, ์ฑํ
๋ฐฉ์ ๋ํ ์์ธ ์ ๋ณด๋ฅผ ๊ฐ์ ธ์ฌ ๋ meetingInfo
๊ด๋ จ ๋ฐ์ดํฐ๋ฅผ ํจ๊ป ๊ฐ์ ธ์ค๊ณ ์๋๋ฐ ๋ฑํ ์ฐ์ด์ง๋ ์๋ ๊ฒ ๊ฐ์ต๋๋ค. ํด๋น ๋ฐ์ดํฐ๋ฅผ ๋ฐํํ๋ ์ด์ ๊ฐ ๋ฐ๋ก ์๋์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฑํ ๋ฐฉ ์์ธ ์ ๋ณด ์กฐํ API ์๋ต์ ํ๋ก์ ํธ ์์ธ ์ ๋ณด, ์์น, ์๊ฐ์ด ํ์ ํ์ฌ ์๋ต์ผ๋ก ์ ์กํด์ฃผ๊ณ ์์ต๋๋ค. -> ์ฑํ ๋ฐฉ ์ ์์ ์์ ๋ณด์ด๋ ํ๋ก์ ํธ ์งํ ์์น ๊ด๋ จ ์ ๋ณด๊ฐ ์์ธ ์ ๋ณด ์กฐํ API๋ก ๋ฐํ๋ฉ๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๋ฐ์ ์ผ๋ก ๊น๋ํ๊ฒ ๋ฆฌํฉํ ๋ง์ด ์ ๋ ๊ฒ ๊ฐ์ต๋๋ค! ๋จ์ ์ฝ๋ฉํธ ํ์ธ ๋ถํ๋๋ ค์~๐๐ป
๐ ๊ฐ๋ฐ ์ฌํญ
ChatUser
์ChatRoom
Entity๋ฅผ ์ฌ์ฉํ์ง ์๊ณ ,ChatRoom
Document๋ฅผ ํ์ฉํ์ฌ ์ฑํ ๋ฐฉ ์ ๋ณด๋ฅผ ์ ์ฅํ๋๋ก ๋ณ๊ฒฝํ์ต๋๋ค.ChatRoom
Document๋ฅผ ํ์ฉํจ์ ๋ฐ๋ผ ๋ง์ง๋ง ์ฑํ ๊ธฐ๋ก์ ์ฑํ ์์ฑ์ChatRoom
Document์ ์ ์ฅํ๋๋ก ๋ฆฌํฉํ ๋ง์ ์งํํ์ต๋๋ค.์ฑํ ๋ฐฉ ๋ฆฌ์คํธ ์กฐํ API ์๋ต ๊ฐ์ด ๋ณ๊ฒฝ๋์์ต๋๋ค.(ํ๋ก ํธ์ ํ์๋์ง ์์ ๋ถ๋ถ์ด์ด์ ์ด์ ์๋ต์ผ๋ก ๋กค๋ฐฑํ์ต๋๋ค. | 24.04.25 ์ถ๊ฐ)๊ธฐ์กด ์ฑํ ์๋ ์ ์ ์ ๋ณด๋ฅผ ์ ๊ณตํ๋ ์๋ต ๊ฐ์์ ํ๋ก์ ํธ ์์ธ ์ ๋ณด๋ฅผ ์ ๊ณตํ๋๋ก ๋ณ๊ฒฝ๋์์ต๋๋ค.์ด์ ๋ฒํธ
ํน์ด ์ฌํญ ๐ซถ