Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#21 oauth2 develop language #153

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

tidavid1
Copy link
Member

๐Ÿš€ ๊ฐœ๋ฐœ ์‚ฌํ•ญ

  • ์‚ฌ์šฉ์ž์˜ Github ๊ธฐ๋ฐ˜ ์ฃผ ์‚ฌ์šฉ ๊ฐœ๋ฐœ ์–ธ์–ด ์ถ”์ถœ ๊ธฐ๋Šฅ์„ ๊ฐœ๋ฐœํ–ˆ์Šต๋‹ˆ๋‹ค.

์ด์Šˆ ๋ฒˆํ˜ธ

ํŠน์ด ์‚ฌํ•ญ ๐Ÿซถ

  • Github REST Api ํ˜ธ์ถœ์„ ์œ„ํ•œ access Token์ด ํ•„์š”๋กœ ํ•˜์—ฌ(์—†์œผ๋ฉด ip ๋‹น ํ•œ์‹œ๊ฐ„ 60ํšŒ ํšŸ์ˆ˜์ œํ•œ) access token์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค
    • ์ด๋กœ ์ธํ•ด yaml ์—…๋ฐ์ดํŠธ๊ฐ€ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค! v8
  • ๊ธฐ์กด ๋กœ๊ทธ์ธ ๊ณผ์ •์—์„œ ์ง„ํ–‰ํ•˜๊ธฐ๋กœ ํ•œ ์‚ฌํ•ญ์„ ๋กœ๊ทธ์ธ ์ดํ›„ api ํ˜ธ์ถœ๋กœ ๋ถ„๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค
    • ์‚ฌ์œ : api ํ˜ธ์ถœ ๊ณผ์ • ์‹œ๊ฐ„์ด ๋„ˆ๋ฌด ์˜ค๋ž˜ ๊ฑธ๋ฆฝ๋‹ˆ๋‹ค..

@tidavid1 tidavid1 added โญ๏ธ Feat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๐ŸŽฏ MVP1 mvp1 ๊ฐœ๋ฐœ์‚ฌํ•ญ labels Feb 22, 2024
@tidavid1 tidavid1 self-assigned this Feb 22, 2024
Copy link

Test Results

0 testsโ€‚ ยฑ0โ€‚โ€ƒโ€ƒ0 โœ… ยฑ0โ€‚โ€ƒโ€ƒ0s โฑ๏ธ ยฑ0s
0 suites ยฑ0โ€‚โ€ƒโ€ƒ0 ๐Ÿ’ค ยฑ0โ€‚
0 filesโ€„โ€‚ ยฑ0โ€‚โ€ƒโ€ƒ0 โŒ ยฑ0โ€‚

Results for commit a5c5491.โ€ƒยฑ Comparison against base commit cc1d49f.

}

public Map<String, Integer> updateUserDevelopLanguage(String repositoryUrl) {
WebClient webClient = WebClient.builder()
Copy link
Collaborator

@JIN-076 JIN-076 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์™ธ๋ถ€ API ํ˜ธ์ถœ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋กœ, webflux์˜ webclient๋ฅผ ์„ ํƒํ•œ ์ด์œ ? ๋˜๋Š” ๊ธฐ์ค€?์ด ์žˆ์—ˆ๋Š”์ง€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค! (๋น„๋™๊ธฐ์ ์œผ๋กœ ์ฒ˜๋ฆฌํ•ด์•ผํ•˜๋Š” ์ž‘์—…์ด๋ผ๋Š” ์ ์ด ๊ฐ€์žฅ ํฐ ์ด์œ ์˜€์„๊นŒ์š”?๐Ÿค”)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RestClient๊ฐ€ ์Šคํ”„๋ง 5.0 ์ดํ›„๋กœ ์œ ์ง€๋ณด์ˆ˜๊ฐ€ ํ•„์š”ํ•˜๋‹ค๋Š” ํŒ๋‹จ์— ์ˆ˜์ •ํ•˜๊ณ ์žˆ๋Š” ์ค‘์ด๋ผ๊ณ  ์•Œ๊ณ  ์žˆ์–ด์„œ ์ฐจ์„ ์ฑ…์ธ WebClient๋ฅผ ํ™œ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค!

@tidavid1 tidavid1 merged commit b9b2168 into develop Feb 23, 2024
3 checks passed
@tidavid1 tidavid1 deleted the feat/#21-oauth2_develop_language branch February 23, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ๏ธ Feat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๐ŸŽฏ MVP1 mvp1 ๊ฐœ๋ฐœ์‚ฌํ•ญ
Projects
None yet
2 participants