Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raster_to_vector creates artifacts due to tile regridding #253

Open
JeroenVerstraelen opened this issue Jan 16, 2024 · 2 comments
Open

raster_to_vector creates artifacts due to tile regridding #253

JeroenVerstraelen opened this issue Jan 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@JeroenVerstraelen
Copy link
Contributor

Before converting the raster to vectors, the raster_to_vector method regrids the rdd to become one single tile (or multiple very large ones) if the rdd is too big:
https://github.com/Open-EO/openeo-geotrellis-extensions/blob/master/openeo-geotrellis/src/main/scala/org/openeo/geotrellis/OpenEOProcesses.scala#L482

When raster_to_vector is used in the parcel delineation notebook it appears that this regridding causes artifacts to appear.

Input:
raster_to_vector_input

Output:
raster_to_vector_issue

@JeroenVerstraelen JeroenVerstraelen added the bug Something isn't working label Jan 16, 2024
@JeroenVerstraelen JeroenVerstraelen self-assigned this Jan 16, 2024
@jdries jdries assigned jdries and unassigned JeroenVerstraelen Jan 25, 2024
@jdries
Copy link
Contributor

jdries commented Jan 25, 2024

I pushed a simple fix and improved the unit test.
Still I noticed that vectorization did not seem to include the full original raster for some reason.
Run the unit test modified in this issue to observe current behaviour!

@JeroenVerstraelen JeroenVerstraelen assigned bossie and unassigned jdries Sep 3, 2024
@jdries
Copy link
Contributor

jdries commented Sep 6, 2024

Proposed solution: add some overlap to the tiles, then vectorize, then perform a union that merges overlapping polygons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants