Derelict desctruction is not a kill #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates from master project
…increases it if the target decides to abandon ship when hit.
HiranChaudhuri
force-pushed
the
master
branch
17 times, most recently
from
4d65277
to
be540a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a scenario where the player can increase his rank by searching derelicts left from NPC's conflicts and destroying them.
It increases the player's score when a NPC chooses (as implemented at the core game level, at ShipEntity's takeEnergyDamage) to abandon ship when its energy is too low after a hit from a player's attack, which has the added benefit of allowing players with moral restrictions to killing to improve their ranking (which is necessary for progress in many of the core game careers).