closest(ray, point) #57
OneLoneCoder
started this conversation in
General
Replies: 1 comment
-
I somehow overlooked that there was already a proposal for I have tested the code from #46 with my testing code and it works as expected. I would thus suggest to adopt the solution from #46 since it is way more concise (and most likely more performant) than the one I provided. @meintte feel free to include the code for testing from my branch into yours. When #46 is merged, then I would just close my pull-request. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It had to happen of course! See #54 and #46. One appears to have an optimal implementation, and the other has some testing code. Of course we need both, so maybe its worth somehow mixing the two. Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions