Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Extensions with conflicting fields do not provoke a warning or error #15

Open
kurtraschke opened this issue Jun 11, 2019 · 0 comments
Open

Comments

@kurtraschke
Copy link
Contributor

kurtraschke commented Jun 11, 2019

If multiple extensions register the same field name, this leads to duplicate fields in the output. Extension registration should perform some validation to ensure that registered extensions' fields do not conflict in harmful ways.

When reading or writing, re-registering the same extension class should not be harmful (that is, onebusaway-csv-entities should do the right thing).

Arguably, registering a different extension class which defines a field with the same name and data type as an existing field is also not harmful (and thus should not provoke an error).

Originally posted by @sdjacobs in OneBusAway/onebusaway-gtfs-modules#115 (comment)

@kurtraschke kurtraschke changed the title > Note: There is no deconfliction performed: if multiple transforms are invoked in a single operation, and they register different extensions which use the same column names on the same objects, undefined behavior may result. Extensions with conflicting fields do not provoke a warning or error Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant