-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QATERIAL_ENABLE_ICONS=OFF code path is broken. #150
Comments
You are right, as this option is not tested in CI. |
I could. Does the dummy code look appropriate to you? I have zero knowledge of the programming languages involved here and this report is the result of my work towards packaging an application in Guix. |
I will do the appropriate PR, and add the appropriate tests in CI. The file that is generated should be |
#151 should fix your issue :) |
https://github.com/OlivierLDff/Qaterial/blame/cf5a5ef064c3deaaf54faff722a808544e7a87f0/cmake/QaterialGenerateIcons.cmake#L184
The last update to the function introduced new arguments, but this change was not implemented in the ENABLE_ICONS=OFF branch.
I was able to complete the compilation with the attached change, but this patch is a blind copy-paste of code with some cuts and renames — the chance that this is the correct solution is very low.
PS: To my frustration, GitHub does not allow me to attach neither a .patch, nor a .cmake file, so I am dumping the .patch below:
The text was updated successfully, but these errors were encountered: