You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In the function olink_one_non_parametric_posthoc the BH multiple testing correction is done inside the group_by and before ungroup.
To Reproduce
Steps to reproduce the behavior:
Check lines 218-221 and 235-238 in file Olink_one_non_parametric.R to see how it is done for olink_one_non_parametric
Check lines 393-394 and 407-409 in file Olink_one_non_parametric.R to see how it is done for olink_one_non_parametric_posthoc
Expected behavior
BH correction should be performed after data is ungrouped.
System Information:
OS: all
R Version: all
Additional context
Remove BH correction from rstatix::wilcox_test and FSA::dunnTest, and perform it after ungrouping using stats::p.adjust. Also make sure to keep both raw and adjusted p-value in the output.
The text was updated successfully, but these errors were encountered:
Describe the bug
In the function
olink_one_non_parametric_posthoc
the BH multiple testing correction is done inside thegroup_by
and beforeungroup
.To Reproduce
Steps to reproduce the behavior:
olink_one_non_parametric
olink_one_non_parametric_posthoc
Expected behavior
BH correction should be performed after data is ungrouped.
System Information:
Additional context
Remove BH correction from
rstatix::wilcox_test
andFSA::dunnTest
, and perform it after ungrouping usingstats::p.adjust
. Also make sure to keep both raw and adjusted p-value in the output.The text was updated successfully, but these errors were encountered: