[NIT-2803] Raise error when db is missing the chain config #2684
+46
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
|
I recommend checking "hide whitespace" when reading the diff. |
If the chain config is missing from the database, it is probably corrupt and the user should take action instead of letting the initialization code run.
gligneul
force-pushed
the
gligneul/database-missing-chain-config
branch
from
8dad450
to
3d1ee13
Compare
gligneul
changed the title
|
I wonder if this would break arbitrum classic state import, as the db exported from arbitrum classic probably doesn't have a chain config |
Good point. I will see how to test it and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the chain config is missing from the database, it is probably corrupt and the user should take action instead of letting the initialization code run.