Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbwasm revert fix #2656

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Arbwasm revert fix #2656

merged 3 commits into from
Sep 20, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Sep 10, 2024

pulls in: OffchainLabs/nitro-contracts#249

This PR only makes ArbWasm revert in arbos < 32 and not-revert in 32.
The way this is achieved is tested in a separate PR: #2655

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 10, 2024
precompiles/ArbWasm.go Show resolved Hide resolved
PlasmaPower
PlasmaPower previously approved these changes Sep 10, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we need to remember to re-apply the contracts change to change the return type

@tsahee tsahee changed the base branch from master to arbos_v32_debug September 13, 2024 03:07
@tsahee tsahee added the ArbOS label Sep 13, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 6c62bf8 into arbos_v32_debug Sep 20, 2024
9 checks passed
@tsahee tsahee deleted the arbwasm_revert_fix branch September 20, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArbOS design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants