Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable preimage validation in JIT #2620

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Disable preimage validation in JIT #2620

merged 2 commits into from
Sep 5, 2024

Conversation

PlasmaPower
Copy link
Collaborator

@PlasmaPower PlasmaPower commented Aug 29, 2024 •
edited
Loading

This turned out to be a bigger performance cost than initially anticipated

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 29, 2024
@PlasmaPower PlasmaPower marked this pull request as ready for review September 5, 2024 20:29
joshuacolvin0
joshuacolvin0 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 2db3c70 into master Sep 5, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the disable-jit-preimage-validation branch September 5, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @joshuacolvin0