Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BOLD state provider for overflow assertions #2201

Merged
merged 43 commits into from
Mar 28, 2024

Conversation

PlasmaPower
Copy link
Collaborator

Points into #2175

Theoretically complete but untested and unit tests need updated

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Mar 22, 2024
@rauljordan rauljordan marked this pull request as ready for review March 28, 2024 14:15
@rauljordan rauljordan merged commit 6ee4ec0 into sepolia-tooling-merge Mar 28, 2024
6 checks passed
@rauljordan rauljordan deleted the overflow-assertions-state-provider branch March 28, 2024 14:16
@@ -112,6 +112,39 @@ func GlobalStatePositionsAtCount(
return startPos, GlobalStatePosition{batch, posInBatch + 1}, nil
}

func FindBatchContainingMessageIndex(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function just exists somewhere else now. We should look around for it to make sure we aren't duplicating code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants