Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaxFeeBidMultipleBips to respect rbf minimums [NIT-2371] #2199

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

PlasmaPower
Copy link
Collaborator

I've confirmed this fixes the TestFeeAndTipCaps_RBF_RisingBlobFee_FallingBaseFee test in the test-feeAndTipCaps branch.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Mar 22, 2024
@PlasmaPower PlasmaPower changed the title Fix MaxFeeBidMultipleBips to respect rbf minimums Fix MaxFeeBidMultipleBips to respect rbf minimums [NIT-2371] Mar 22, 2024
Tristan-Wilson
Tristan-Wilson previously approved these changes Mar 22, 2024
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit 5b1871c into master Mar 25, 2024
8 checks passed
@Tristan-Wilson Tristan-Wilson deleted the rbf-max-multiple branch March 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants