Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generated method names in tests #2181

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Update generated method names in tests #2181

merged 3 commits into from
Mar 25, 2024

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Mar 11, 2024 •
edited by joshuacolvin0
Loading

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Mar 11, 2024
@anodar anodar marked this pull request as ready for review March 12, 2024 00:00
@anodar anodar requested a review from PlasmaPower March 12, 2024 00:00
@joshuacolvin0 joshuacolvin0 mentioned this pull request Mar 25, 2024
Merged
Tristan-Wilson
Tristan-Wilson previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, thanks for doing this. Will make future contract upgrades safer.

LGTM

joshuacolvin0
joshuacolvin0 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit adab53d into master Mar 25, 2024
8 checks passed
@joshuacolvin0 joshuacolvin0 deleted the postfix-signatures branch March 25, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@Tristan-Wilson Tristan-Wilson Tristan-Wilson left review comments

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

@magicxyyz magicxyyz Awaiting requested review from magicxyyz

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anodar @joshuacolvin0 @Tristan-Wilson