Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce initial max tip cap for dataposter #1797

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Aug 8, 2023

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 8, 2023
@anodar anodar marked this pull request as ready for review August 8, 2023 15:25
@anodar anodar requested a review from PlasmaPower August 8, 2023 15:25
@@ -599,6 +601,7 @@ var DefaultDataPosterConfig = DataPosterConfig{
UrgencyGwei: 2.,
MaxMempoolTransactions: 64,
MinTipCapGwei: 0.05,
MaxTipCapGwei: 0.1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's increase the default config value to 5 gwei. I think that's large enough to let us get in the tx quickly during congestion, but also not too large that we can't continue escalating the tip safely with replace-by-fee.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 9018996 into master Aug 10, 2023
7 checks passed
@PlasmaPower PlasmaPower deleted the dataposter-config-initial-tip branch August 10, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants