Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lint about useless drop #1782

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix clippy lint about useless drop #1782

merged 3 commits into from
Jul 24, 2023

Conversation

PlasmaPower
Copy link
Collaborator

The drop was not there to actually do anything but just to indicate that the current state reference shouldn't be used after resume. I've replaced it with a comment explaining that.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 24, 2023
joshuacolvin0
joshuacolvin0 previously approved these changes Jul 24, 2023
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1782 (6a00aa1) into master (ea6cbab) will increase coverage by 3.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1782      +/-   ##
==========================================
+ Coverage   53.60%   56.86%   +3.25%     
==========================================
  Files         209      222      +13     
  Lines       29277    33446    +4169     
==========================================
+ Hits        15695    19018    +3323     
- Misses      11235    12085     +850     
+ Partials     2347     2343       -4     

@PlasmaPower PlasmaPower merged commit af87ba2 into master Jul 24, 2023
7 checks passed
@PlasmaPower PlasmaPower deleted the fix-clippy-drop-lint branch July 24, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants