-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ArbitrumContractTx type transactions #1731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only, LGTM
system_tests/retryable_test.go
Outdated
@@ -52,30 +52,38 @@ func retryableSetup(t *testing.T) ( | |||
delayedBridge, err := arbnode.NewDelayedBridge(l1client, l1info.GetAddress("Bridge"), 0) | |||
Require(t, err) | |||
|
|||
lookupSubmitRetryableL2TxHash := func(l1Receipt *types.Receipt) common.Hash { | |||
lookupL2Hash := func(l1Receipt *types.Receipt) common.Hash { | |||
messages, err := delayedBridge.LookupMessagesInRange(ctx, l1Receipt.BlockNumber, l1Receipt.BlockNumber, nil) | |||
Require(t, err) | |||
if len(messages) == 0 { | |||
Fatal(t, "didn't find message for retryable submission") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed to not just reference retryables now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
system_tests/retryable_test.go
Outdated
continue | ||
} | ||
txs, err := arbos.ParseL2Transactions(message.Message, params.ArbitrumDevTestChainConfig().ChainID, nil) | ||
Require(t, err) | ||
for _, tx := range txs { | ||
if tx.Type() == types.ArbitrumSubmitRetryableTxType || tx.Type() == types.ArbitrumDepositTxType { | ||
if txTypes[tx.Type()] { | ||
submissionTxs = append(submissionTxs, tx) | ||
} | ||
} | ||
} | ||
if len(submissionTxs) != 1 { | ||
Fatal(t, "expected 1 tx from retryable submission, found", len(submissionTxs)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed to not just reference retryables now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…itro into test-cases-contractTxType
No description provided.