Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store context in structs #1714

Closed
wants to merge 1 commit into from
Closed

Don't store context in structs #1714

wants to merge 1 commit into from

Conversation

anodar
Copy link
Contributor

@anodar anodar commented Jun 21, 2023

  • drop contexts from Node (this one isn't even used) and multiplexerBackend structs. (because: [0])
  • move Node structure and it's functions to the beginning of the file (that way it's easier to follow what's the node's functionality and what accounts for its' state)
  • rename CreateNode to New as arbnode.CreateNode is redundant and arbnode.New already implies node (more in [1])

[0] https://go.dev/blog/context-and-structs
[1] https://google.github.io/styleguide/go/decisions#package-vs-exported-symbol-name

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 21, 2023
@anodar anodar requested a review from PlasmaPower June 21, 2023 13:31
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no large restructures without an immediate reason until we have execution-separation merged.
Restructures should either be on top of execution-service-8 or wait..

@anodar
Copy link
Contributor Author

anodar commented Jun 21, 2023

Closing per tsahee's request #1714 (review).

@anodar anodar closed this Jun 21, 2023
@anodar anodar deleted the refactor branch June 22, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants