Parse new BatchPostingReport field extraGas #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Codecov Report
@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
+ Coverage 56.21% 56.22% +0.01%
==========================================
Files 217 217
Lines 32617 32628 +11
==========================================
+ Hits 18335 18345 +10
- Misses 12061 12080 +19
+ Partials 2221 2203 -18 |
|
This is no longer necessary with the new BatchPostingReport mechanism in OffchainLabs/nitro-contracts#26 |
|
Reopening because this method is more accurate and what we'll want to move to longer term |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also pulls in a contracts change to use this new field to improve the accuracy of L1 gas charging on L3 chains: OffchainLabs/nitro-contracts#28