Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate testnode #1679

Merged
merged 14 commits into from
Jun 21, 2023
Merged

Separate testnode #1679

merged 14 commits into from
Jun 21, 2023

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Jun 6, 2023

move testnode to a separate submodule.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1679 (a365467) into master (d6a5090) will increase coverage by 26.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1679       +/-   ##
===========================================
+ Coverage   29.88%   56.12%   +26.24%     
===========================================
  Files         210      217        +7     
  Lines       31263    32600     +1337     
===========================================
+ Hits         9342    18298     +8956     
+ Misses      20906    12106     -8800     
- Partials     1015     2196     +1181     

Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is working locally

@PlasmaPower PlasmaPower merged commit d3cff76 into master Jun 21, 2023
8 checks passed
@PlasmaPower PlasmaPower deleted the separate-testnode branch June 21, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants