Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Das factory not include gcs option #2768

Closed
incubator4 opened this issue Nov 5, 2024 · 4 comments
Closed

Das factory not include gcs option #2768

incubator4 opened this issue Nov 5, 2024 · 4 comments

Comments

@incubator4
Copy link

Describe the bug
This is a bug about PR #2643
I've tried self build master image and use gcs as storage backend, it says At least one of --data-availability.(local-db-storage|local-file-storage|s3-storage) must be enabled.
Due to

nitro/das/factory.go

Lines 170 to 175 in b4e27fc

if !config.LocalDBStorage.Enable &&
!config.LocalFileStorage.Enable &&
!config.S3Storage.Enable {
return nil, nil, nil, nil, nil, errors.New("At least one of --data-availability.(local-db-storage|local-file-storage|s3-storage) must be enabled.")
}
// Done checking config requirements

GCS Storage should be append into this check
To Reproduce
The latest nitro das with only gcs enable

@incubator4
Copy link
Author

incubator4 commented Nov 5, 2024

additional issue, das pod start after both set local and gcs storage, but got error with
{"t":"2024-11-05T10:41:27.834042508Z","lvl":"warn","msg":"Served das_healthCheck","conn":"127.0.0.1:47812","reqid":"0","duration":"10.800134ms","err":"could not check permissions: googleapi: Error 400: Invalid argument., invalid"}

it might be something issue with

perms, err := bucket.IAM().TestPermissions(ctx, permissions)
if err != nil {
return fmt.Errorf("could not check permissions: %w", err)
}

@joshuacolvin0
Copy link
Member

You are welcome to open a PR to fix these issues, but we don't directly support GCS at this time.

@joshuacolvin0 joshuacolvin0 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
@incubator4
Copy link
Author

You are welcome to open a PR to fix these issues, but we don't directly support GCS at this time.

I'd like to create PR after the custoimze image which I modifty to support GCS running for a while.
at the mean time, should s3 backend support custom endpoints to support minio, cloudflare d2 or anyother object storage which support s3 protocol?

@joshuacolvin0
Copy link
Member

we have not tested minio, etc. but you are free to do your own testing and submit PRs if fixes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants