From f677b58e7cacfb8141f2e9cbc7a9fa73180ff784 Mon Sep 17 00:00:00 2001 From: gzeon Date: Tue, 3 Sep 2024 18:00:46 +0800 Subject: [PATCH] ci: remove 4844 testnode ref (#241) * ci: remove 4844 testnode ref * ci: use more recent goomy-blob * ci: fix tag * fix: whitelist yarn audit issue --- .github/workflows/contract-tests.yml | 1 - audit-ci.jsonc | 4 +++- test/contract/toolkit4844.ts | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/contract-tests.yml b/.github/workflows/contract-tests.yml index 67e26d6f..265aef22 100644 --- a/.github/workflows/contract-tests.yml +++ b/.github/workflows/contract-tests.yml @@ -129,7 +129,6 @@ jobs: - uses: OffchainLabs/actions/run-nitro-test-node@main with: - nitro-testnode-ref: deneb-integration args: --pos no-token-bridge: true diff --git a/audit-ci.jsonc b/audit-ci.jsonc index 0e2ab97a..bc17767f 100644 --- a/audit-ci.jsonc +++ b/audit-ci.jsonc @@ -63,6 +63,8 @@ // Elliptic's ECDSA missing check for whether leading bit of r and s is zero - only used in dev "GHSA-977x-g7h5-7qgw", // Server-Side Request Forgery in axios - "GHSA-8hc4-vh64-cxmj" + "GHSA-8hc4-vh64-cxmj", + // Regular Expression Denial of Service (ReDoS) in micromatch + "GHSA-952p-6rrq-rcjv" ] } diff --git a/test/contract/toolkit4844.ts b/test/contract/toolkit4844.ts index 258a2400..ecd9fb85 100644 --- a/test/contract/toolkit4844.ts +++ b/test/contract/toolkit4844.ts @@ -110,7 +110,7 @@ export class Toolkit4844 { data: string ) { const blobStr = blobs.reduce((acc, blob) => acc + ' -b ' + blob, '') - const blobCommand = `docker run --network=nitro-testnode_default ethpandaops/goomy-blob@sha256:8fd6dfe19bedf43f485f1d5ef3db0a0af569c1a08eacc117d5c5ba43656989f0 blob-sender -p ${privKey} -r http://geth:8545 -t ${to} -d ${data} --gaslimit 1000000${blobStr} 2>&1` + const blobCommand = `docker run --network=nitro-testnode_default ethpandaops/goomy-blob:master-91c1ad7 blob-sender -p ${privKey} -r http://geth:8545 -t ${to} -d ${data} --gaslimit 1000000${blobStr} 2>&1` const res = execSync(blobCommand).toString() const txHashRegex = /0x[a-fA-F0-9]{64}/ const match = res.match(txHashRegex)