feat: add support for non-18 decimal native tokens #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
reviewed
Sep 16, 2024
| @@ -43,7 +43,7 @@ export function TokenBalance({ | |||
| <span className="font-light">{prefix}</span> | |||
| <span aria-label={`${tokenSymbol} balance amount on ${on}`}> | |||
| {formatAmount(balance, { | |||
| decimals: forToken.decimals | |||
| decimals: isParentChain ? forToken.decimals : 18 | |||
There was a problem hiding this comment.
forToken.decimals will be different when it's source vs destination, so this will require some conditional adjustments even outside of this file
my understanding here is that i have 8,999.9998 TN, but when it's at destination network box, we used the source chain's number of decimals to format it
see how the amount is different because the number of decimals even though the only thing i did was to toggle the source and destination chains:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.