Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list of subnode should be dynamically computed #29

Open
NicolasAnquetil opened this issue Jun 23, 2021 · 3 comments
Open

list of subnode should be dynamically computed #29

NicolasAnquetil opened this issue Jun 23, 2021 · 3 comments
Assignees

Comments

@NicolasAnquetil
Copy link
Collaborator

either by offering a callback on the expand action (that would allow a client to recompute the list)
or by allowing a block for the list of subnodes

@NicolasAnquetil NicolasAnquetil changed the title list of subnode shgould be dynamically computed list of subnode should be dynamically computed Jun 23, 2021
@akevalion akevalion self-assigned this Jun 25, 2021
@bergel
Copy link
Contributor

bergel commented Jun 29, 2021

I believe we could do this by creating subclasses of HNode specialized in what it should be open (e.g., package)

@NicolasAnquetil
Copy link
Collaborator Author

Not sure, because even if we know it is a node for a Package, there may be different kind of sub-nodes that the user would want to have.

I really believe the sub node should be:

  • [Pharo way] computed from a block (taking the hnode rawModel as argument), or
  • [Java way] recomputed by the user every time it is needed, and this would require a callback from the visualization to some method provided by the user

The first one seems a lot better

@bergel
Copy link
Contributor

bergel commented Sep 7, 2021

Related to #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants