Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footprint file suffix options #54

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

hchagani-oasislmf
Copy link
Contributor

@hchagani-oasislmf hchagani-oasislmf commented Aug 2, 2023

Add footprint file suffix options

An optional footprint_set model setting has been added to allow for the selection of footprint file according to the file suffix, which acts as the identifier. This allows footprints to be stored in multiple files rather than in a single master file. This is related to OasisLMF PR OasisLMF/OasisLMF#1352.

@hchagani-oasislmf hchagani-oasislmf marked this pull request as ready for review August 3, 2023 09:51
@hchagani-oasislmf hchagani-oasislmf self-assigned this Aug 3, 2023
@hchagani-oasislmf hchagani-oasislmf added the enhancement New feature or request label Aug 3, 2023
Copy link
Contributor

@sambles sambles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sambles sambles merged commit 49f89c1 into main Aug 4, 2023
9 checks passed
sambles pushed a commit that referenced this pull request Aug 4, 2023
@hchagani-oasislmf hchagani-oasislmf deleted the feature/multiple-footprint-file-options branch August 10, 2023 01:13
@awsbuild awsbuild modified the milestones: 3.1.1rc1, 3.1.1 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants