Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue when categorical column have a default value #115

Merged
merged 2 commits into from
May 16, 2024

Conversation

sstruzik
Copy link
Contributor

fix issue when categorical column have a default value

UseReinsDates is a string column with a default, this case was not handled well when loading ri_info

@sstruzik sstruzik added the bug Something isn't working label May 16, 2024
@sstruzik sstruzik requested a review from johcarter May 16, 2024 11:09
@sstruzik sstruzik self-assigned this May 16, 2024
@johcarter
Copy link
Contributor

What is the process for backporting a fix to versions of ODS Tools which is used in an older version of Oasis ? This one is needed for the version of ODS_Tools for OasisLMF1.28.2 for example.

@sstruzik sstruzik merged commit 24607ff into main May 16, 2024
15 checks passed
@sambles
Copy link
Contributor

sambles commented May 21, 2024

@johcarter @sstruzik

oasislmf==1.28.x is locked to ods-tools=3.1.x so we need to backport to branch stable/3.1.x --> creating a new release 3.1.5
https://github.com/OasisLMF/OasisLMF/blob/957dc6b86b5a30484306af11ec2aa5baec65ed71/requirements-package.in#L10

Please ping me when needed, otherwise it might get missed from a release

sambles pushed a commit that referenced this pull request May 21, 2024
* fix issue when categorical column have a default value
sambles pushed a commit that referenced this pull request May 21, 2024
* fix issue when categorical column have a default value
@sambles sambles deleted the fix/read_categorical_with_default branch May 21, 2024 12:52
@awsbuild awsbuild modified the milestones: 3.1.5, 3.2.4 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working LTS - 1.28 LTS - 2.3
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants