Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should 'OEDVersion' be a required field? #203

Closed
4 tasks done
MattDonovan82 opened this issue Jun 28, 2024 · 2 comments
Closed
4 tasks done

Should 'OEDVersion' be a required field? #203

MattDonovan82 opened this issue Jun 28, 2024 · 2 comments
Assignees
Labels
discussion Further information is requested major major release (breaking change)

Comments

@MattDonovan82
Copy link
Contributor

Description

Should the OEDVersion field in all four OED input files be a 'required' field?

Reasons for change

Currently an optional field but making it 'Required' ensures a solid reference to the version of OED. Its' been discussed as a possibility and so I'm just putting it out there for the community to comment and get some feedback.

Scope of change

  • Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

This will be a breaking change for most validation exercises so it will go into OED v4.0.0 which is a major update.

Data type, default values, are blanks allowed, list valid values

Field Name Data type Default values Blanks allowed Valid values
Acc; Loc; ReinsInfo; ReinsScope Varcher(10) Latest version of OED No 4.0.0
@MattDonovan82
Copy link
Contributor Author

Just to bring it to your attention @johcarter @benhayes21 @sstruzik @aiste-kalinauskaite

@MattDonovan82 MattDonovan82 self-assigned this Jun 28, 2024
@MattDonovan82 MattDonovan82 added discussion Further information is requested major major release (breaking change) labels Jun 28, 2024
@MattDonovan82
Copy link
Contributor Author

MattDonovan82 commented Jul 12, 2024

Further discussions suggest this should remain an 'optional' field as it will cause too much disruption to make it 'required' and it's not ideal to have this for every row of data in all four files. There was an idea to include this in the model settings file instead.

Any further comments @sstruzik @johcarter @benhayes21 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Further information is requested major major release (breaking change)
Projects
Status: Done
Development

No branches or pull requests

2 participants